-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Support stream init diagnostics events for FDv2. #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+593
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
Member
Author
|
bugbot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
tanderson-ld
approved these changes
Feb 9, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Feb 12, 2026
🤖 I have created a release *beep* *boop* --- ## [7.12.0](launchdarkly-java-server-sdk-7.11.0...launchdarkly-java-server-sdk-7.12.0) (2026-02-12) ### Features * Support stream init diagnostics events for FDv2. ([#133](#133)) ([cb01449](cb01449)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Release-only version and changelog updates; no functional code changes beyond the version constant. > > **Overview** > Bumps `launchdarkly-java-server-sdk` to **7.12.0** (from `7.11.0`) by updating release metadata (`.release-please-manifest.json`), Gradle version (`gradle.properties`), and the internal `Version.SDK_VERSION` constant. > > Updates `CHANGELOG.md` with the `7.12.0` release notes, highlighting *support for stream init diagnostics events for FDv2*. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8cb16d7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches FDv2 streaming lifecycle/error handling and restart behavior, which could affect reconnection and initialization semantics; changes are guarded by extensive new unit tests and are largely additive (diagnostic recording).
Overview
Adds FDv2 streaming stream-init diagnostics by plumbing a
DiagnosticStoreintoStreamingSynchronizerImpl(viaDataSystemComponents) and recording init timestamp/duration with afailedflag.Updates streaming error/restart paths to distinguish deliberate restarts (e.g.
goodbye/caller-initiated) from failures, reset timing after the first successful changeset, and record failures on conversion/protocol/parsing errors and unexpected thread termination. Tests are expanded to validate diagnostics across success, HTTP/network errors, invalid data, and repeated restarts (including null-store safety).Written by Cursor Bugbot for commit ee478d9. This will update automatically on new commits. Configure here.